[julia] Install the CompilerExplorer.jl after installing the compiler
#1264
Conversation
| @@ -3,7 +3,8 @@ compilers: | |||
| type: tarballs | |||
| compression: gz | |||
| dir: julia-{name} | |||
| check_exe: bin/julia --version | |||
| julia_exe: bin/julia | |||
There was a problem hiding this comment.
Can I define custom fields in this yaml file? I did it for convenience, to avoid repeating some things, but if it doesn't work I'll change this;
There was a problem hiding this comment.
you can; and that's the intention to let you cascading-ly refer to things later on as you do.
| @@ -21,3 +22,7 @@ compilers: | |||
| url: https://julialangnightlies-s3.julialang.org/bin/linux/x86_64/julia-latest-linux-x86_64.tar.gz | |||
| strip_components: 1 | |||
| create_untar_dir: true | |||
| depot: {destination}/depot | |||
There was a problem hiding this comment.
I have no clue what path destination is, I saw it in
Line 14 in f7d9fb5
{destination}/depot is something like /opt/compiler-explorer/julia-{name} or what.
There was a problem hiding this comment.
You may need to quote some of these things to make them valid yaml
| depot: {destination}/depot | ||
| cejl_revision: 532185e32ed03d340e16922c1da330c973047570 | ||
| after_stage_script: | ||
| - JULIA_DEPOT_PATH={depot} {julia_exe} -e 'using Pkg; Pkg.add(; url="https://github.com/giordano/CompilerExplorer.jl", rev="{ce_revision}"); Pkg.precompile()' |
There was a problem hiding this comment.
Is bin/julia (== {julia_exe}) a sensible way to call the julia executable after it has been installed? I followed the check_exe example.
| depot: {destination}/depot | ||
| cejl_revision: 532185e32ed03d340e16922c1da330c973047570 | ||
| after_stage_script: | ||
| - JULIA_DEPOT_PATH={depot} {julia_exe} -e 'using Pkg; Pkg.add(; url="https://github.com/giordano/CompilerExplorer.jl", rev="{ce_revision}"); Pkg.precompile()' |
There was a problem hiding this comment.
| - JULIA_DEPOT_PATH={depot} {julia_exe} -e 'using Pkg; Pkg.add(; url="https://github.com/giordano/CompilerExplorer.jl", rev="{ce_revision}"); Pkg.precompile()' | |
| - JULIA_DEPOT_PATH={depot}: {julia_exe} -e 'using Pkg; Pkg.add(; url="https://github.com/giordano/CompilerExplorer.jl", rev="{ce_revision}"); Pkg.precompile()' |
Any reason for using {depot} instead of {destination}/local/share/julia?
We likely also need a project + manifest in the LOAD_PATH
There was a problem hiding this comment.
I was planning adding the package to the global environment, so that we don't have to deal with adding a Project.toml/Manifest.toml here (the latter file being problematic, since it's different for each julia version). But I'm open to better solutions.
There was a problem hiding this comment.
So if you use the local depot https://docs.julialang.org/en/v1/base/constants/#Base.DEPOT_PATH
Then we don't need to modify the depot path later one.
I don't think we want to use the default project since the user might try to modify it and this is read-only (might also be fine).
You need : after the path so that we still have the system depot available for the stdlib
|
In order to set |
correct |
This is my initial attempt to address #1259, but there are still things I don't understand, so opening as draft.
CC: @vchuravy.