Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utilize docker compose --profile postgres, and POSTGRES_DOCKER var,
to enable/disable using dockerized postgres.
For using docker compose directly
Now, by default,
docker compose ...
will NOT run a dockerized postgres service. You must provide a valid DATABASE_URL in your environment.To continue using the dockerized postgres service, all
docker compose
commands must include the flag--profile postgres
For using make
The Makefile will read
POSTGRES_DOCKER
in your env file. If it isfalse
, it will not include the postgres docker service. However, ifPOSTGRES_DOCKER=true
(defaults to true if unset), then make will run as before, including postgres docker service (via--profile postgres
) in all of its actions.TL;DR
To disable docker postgres, include
POSTGRES_DOCKER=false
in your .env (or prod.env).To keep using docker postgres, do nothing (if using make), or amend any
docker compose
calls with--profile postgres
.Closes #1749 and #1751