Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable non-docker postgres #1817

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

ballPointPenguin
Copy link
Contributor

utilize docker compose --profile postgres, and POSTGRES_DOCKER var,
to enable/disable using dockerized postgres.

For using docker compose directly

Now, by default, docker compose ... will NOT run a dockerized postgres service. You must provide a valid DATABASE_URL in your environment.
To continue using the dockerized postgres service, all docker compose commands must include the flag --profile postgres

For using make

The Makefile will read POSTGRES_DOCKER in your env file. If it is false, it will not include the postgres docker service. However, if POSTGRES_DOCKER=true (defaults to true if unset), then make will run as before, including postgres docker service (via --profile postgres) in all of its actions.

TL;DR

To disable docker postgres, include POSTGRES_DOCKER=false in your .env (or prod.env).

To keep using docker postgres, do nothing (if using make), or amend any docker compose calls with --profile postgres.

Closes #1749 and #1751

@ballPointPenguin
Copy link
Contributor Author

Prior to #1816, the Github actions are expected to fail

@ballPointPenguin ballPointPenguin merged commit 86ba48f into edge Oct 8, 2024
2 of 3 checks passed
@ballPointPenguin ballPointPenguin deleted the br/enable-non-docker-postgres branch October 8, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant