-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RecentSearch from java
to kt
#5993
base: main
Are you sure you want to change the base?
Conversation
neeldoshii
commented
Dec 4, 2024
•
edited
Loading
edited
- Parent/Part-Of: Parent issue: Migration of Java Code to Kotlin for Enhanced Code Consistency and Maintainability #5928
recentSearches | ||
) | ||
binding.recentSearchesList.adapter = adapter | ||
binding.recentSearchesList.setOnItemClickListener { _, _, position, _ -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion:
Just a followup feature suggestion while using the app. What if we add swipe right, swipe left action on the item to delete particular item?
https://github.com/user-attachments/assets/e9138df6-0340-4330-989f-7a24a080a6af
~ Similar to like this deleting the item by performing swipe action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a nice extra indeed.
Great to implement if it is short and maintainable. :-)
java
to kt
Hi @psh, can you help me in fixing the null pointer? 😊🫡 |
It looks like the test setup is bypassing the normal fragment lifecycle. Normally Android would have called private val binding get() = _binding!! is throwing the exception. Take a look at |
Will fix this by next week. Taking a break due to university exams. |