codegen: remove unnecessary sorting of keys in ID Maps

common-workflow-language · Dec 10, 2024 · 2a9365d · 2a9365d
1 parent c5863dd
commit 2a9365d
Show file tree

Hide file tree

Showing 8 changed files with 1,054 additions and 1,053 deletions.
diff --git a/schema_salad/dotnet/util/Loaders/IdMapLoader.cs b/schema_salad/dotnet/util/Loaders/IdMapLoader.cs
@@ -22,7 +22,7 @@ public object Load(in object doc_, in string baseuri, in LoadingOptions loadingO
         {
             List<object> r = new();
             Dictionary<string, object> d = docDict.Cast<dynamic>().ToDictionary(entry => (string)entry.Key, entry => entry.Value);
-            foreach (string? k in d.Keys.OrderBy(p => p))
+            foreach (string? k in d.Keys)
             {
                 object val = d[k];
                 if (val is IDictionary dictionary)

diff --git a/schema_salad/java/main_utils/IdMapLoader.java b/schema_salad/java/main_utils/IdMapLoader.java
@@ -27,9 +27,7 @@ public T load(
     if (doc instanceof Map) {
       final Map<String, Object> docMap = (Map<String, Object>) doc;
       final List<Object> asList = new ArrayList();
-      final TreeSet<String> sortedKeys = new TreeSet<String>();
-      sortedKeys.addAll(docMap.keySet());
-      for (final String key : sortedKeys) {
+      for (final String key : docMap.keySet()) {
         final Object el = docMap.get(key);
         if (el instanceof Map) {
           final Map<String, Object> v2 = new HashMap<String, Object>((Map<String, Object>) el);

diff --git a/schema_salad/metaschema.py b/schema_salad/metaschema.py
@@ -950,7 +950,7 @@ def load(
     ) -> Any:
         if isinstance(doc, MutableMapping):
             r: list[Any] = []
-            for k in sorted(doc.keys()):
+            for k in doc.keys():
                 val = doc[k]
                 if isinstance(val, CommentedMap):
                     v = copy.copy(val)

diff --git a/schema_salad/python_codegen_support.py b/schema_salad/python_codegen_support.py
@@ -947,7 +947,7 @@ def load(
     ) -> Any:
         if isinstance(doc, MutableMapping):
             r: list[Any] = []
-            for k in sorted(doc.keys()):
+            for k in doc.keys():
                 val = doc[k]
                 if isinstance(val, CommentedMap):
                     v = copy.copy(val)