use @serjek's suggestion. closes #41

colyseus · Oct 25, 2020 · 8f914ad · 8f914ad
1 parent 92bf118
commit 8f914ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/haxelib.json b/haxelib.json
@@ -4,9 +4,9 @@
   "license": "MIT",
   "tags": ["multiplayer", "networking", "websockets", "netcode"],
   "description": "Multiplayer Game Client for Haxe",
-  "version": "0.14.4",
+  "version": "0.14.5",
   "classPath": "src/",
-  "releasenote": "fix compilation with '-dce full'",
+  "releasenote": "fixes 'refId not found' issue.",
   "contributors": ["endel"],
   "dependencies": {
     "colyseus-websocket": "1.0.7"

diff --git a/src/io/colyseus/serializer/schema/Schema.hx b/src/io/colyseus/serializer/schema/Schema.hx
@@ -559,10 +559,16 @@ class Schema implements IRef {
         //
         // FIXME: Type.getClass(previousValue)
         // This may not be a reliable call, in case the previousValue is `null`.
+        // (The unity3d client does not have this problem because it has a different take on this)
+        // TODO:use Type.resolveClass("io.colyseus.serializer.schema.types.MapSchema_XXX")
         //
         var collectionClass = (fieldType == null)
           ? Type.getClass(ref)
-          : Type.getClass(previousValue); // CustomType.getInstance().get(fieldType)
+          : #if (nodejs || js)
+              CustomType.getInstance().get(fieldType)
+            #else
+              Type.getClass(previousValue)
+            #end;
 
         var valueRef: ISchemaCollection = (refs.has(refId))
           ? previousValue