Add support for reading Wireshark SocketCAN log format #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds support for reading Wireshark SocketCAN logs. There is currently a Wireshark pcap decoder in SavvyCAN but not for these types of logs. The new code checks if the pcap file link type is PCAP_LINKTYPE_SOCKETCAN (227) and if not, will fall through to the current default wireshark decoder.
This work is in addition to the PR I will soon create that adds gs_usb (cantact, canable, CAN Bus Debugger etc.) support on Windows as discussed in Issue #238
Let me know if there is anything you'd like me to modify.
Thanks for great work!