Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditional execution of organized interactors #139

Conversation

hedgesky
Copy link
Contributor

Fixes #128.
I've decided to create OrganizedInteractor class to hold organized interactors along with passed options. This class is also responsible to run interactors with regard of passed options. :if and :unless are currently supported; you could pass either a symbol or a proc.

@options = options
end

def call!(context, within_organizer)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather use keyword argument for within_organizer here, but currently gemspec is targeted to Ruby 2.0.

@temkin
Copy link

temkin commented Jun 5, 2018

This is a very good feature! Why not merged yet?

@mikepence
Copy link

+1 huge missing part of organizers

@gustavomazzoni
Copy link

+1

@hedgesky
Copy link
Contributor Author

Hi @laserlemon, I know it's been a while since this conversation was started and probably now this gem isn't in your list of priorities. I'm not going to ask you to invest a lot of your time, but maybe you could merge the PR?
It will help people who want to use the feature. At the same time, leaving it undocumented makes it kind of experimental and leaves you with possibility to change it in future if you'd like to.

@lfv89
Copy link

lfv89 commented Sep 12, 2019

That is a really helpful feature.

@laserlemon do you think you will be able to review this PR anytime soon?

@iriscoopers
Copy link

+1 !

@hedgesky hedgesky closed this Aug 31, 2020
@fedefa
Copy link

fedefa commented Oct 28, 2021

+1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants