Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create an example for a component #753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prakrit55
Copy link

fixing #743

Signed-off-by: Griffin <[email protected]>
@prakrit55
Copy link
Author

@niccokunzmann, we can have a discussion here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12097205435

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.355%

Totals Coverage Status
Change from base Build 12058486016: 0.0%
Covered Lines: 4580
Relevant Lines: 4747

💛 - Coveralls

@niccokunzmann
Copy link
Member

This is the right place. Now, could you copy in an example from the rfc?

@prakrit55
Copy link
Author

This is the right place. Now, could you copy in an example from the rfc?

is there any way to generate rfc files, could you mention any way to do this

@stevepiercy
Copy link
Member

@prakrit55 RFC stands for Request for Comments. The issue to be resolved would be to copy an example from the specific RFC 5545 for one of the given components, and write a Python doctest for it in its method.

I'm not sure why the issue todo for each of the three checked add src/icalendar/tests/todos/example.ics is checked, because I don't see the todo folder in the repo where it says it should be.

@niccokunzmann perhaps you could update the issue description with some more details? I'm not clear myself.

@prakrit55
Copy link
Author

@prakrit55 RFC stands for Request for Comments. The issue to be resolved would be to copy an example from the specific RFC 5545 for one of the given components, and write a Python doctest for it in its method.

I'm not sure why the issue todo for each of the three checked add src/icalendar/tests/todos/example.ics is checked, because I don't see the todo folder in the repo where it says it should be.

@niccokunzmann perhaps you could update the issue description with some more details? I'm not clear myself.

hello @stevepiercy, thanks for the reply, does the repo have any examples you can point me to

@niccokunzmann
Copy link
Member

niccokunzmann commented Dec 2, 2024

@prakrit55, could you have a look at the documentation and the file structure and the issue - the issue points towards

  • what has been done already

I also added links at the bottom. It is a joint effort to make everything clear and I value you stepping forward to improve the project. The challenge for me here is to balance the time it takes to solve it myself with the time it takes on get you on board. So, a PR with one empty file is a small step and I would like you to get a bit familiar with the project by yourself. However, I can also understand that it is hard to get started at all. So, I will point you in some directions and help you when you get stuck. Please have a look at "what was done already" in the issue and give it your bravest, best shot in what you think should go into that file. https://www.rfc-editor.org/info/rfc5545 will help.

Then, please ask again.

@stevepiercy, I will write more into the issue now. It was a copy&paste mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants