Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component._encode: merge instead of ignore parameters on natives #559

Merged
merged 5 commits into from
Sep 24, 2023

Conversation

Zocker1999NET
Copy link
Contributor

Fixes #557

  • converts Component._encode to staticmethod
    • makes testing easier
    • keeps compatibility to existing code
  • introduces test cases for expected behavior
  • changes Component._encode accordingly

- did not reference self at all
- keeps compatibility with existing code
- makes testing easier

Signed-off-by: Felix Stupp <[email protected]>
@jacadzaca
Copy link
Collaborator

hey, big thanks for the PR! Please fill out the CHANGELOG and add yourself to CREDITS as per CONTRIBUTING

@Zocker1999NET
Copy link
Contributor Author

thanks for hint, now also added CHANGELOG & CREDITS entries

@jacadzaca jacadzaca merged commit 6b9d794 into collective:master Sep 24, 2023
8 checks passed
@jacadzaca
Copy link
Collaborator

look OK to me. Thanks for the PR

@Zocker1999NET Zocker1999NET deleted the fix-issue-557 branch September 24, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Component._encode ignores parameters if value is native
2 participants