Strong types, not ignoring the VALUE parameter, better error handling #331
Conversation
|
@thet thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
thet
force-pushed
the
error_handling_2
branch
from
ab231e1 to
9782f02
Compare
Previously, if error occured during the creation of inner type instance from iCalendar string, the error with the name of the bogus property would be stored in the appropriate component's errors attribute along with the error string but the property's value would be removed from the parsed representation. This patch keeps the value even with its parameters at that certain property, the value's type is changed to vText. Should allow implementation of #158 Improves #174
…ctionality change.
thet
force-pushed
the
error_handling_2
branch
from
9782f02 to
ee137f7
Compare
|
@jenkins-plone-org please run jobs |
1 similar comment
|
@jenkins-plone-org please run jobs |
|
@thet, we are in the process of setting up maintenance for this repository again, see #360. It will take some time but I hope, we will get further towards integrating your changes. Thanks a lot for the effort and patience already! Some old Python versions get dropped in the master branch, so you might well be able to live out some new typing features! |
|
I am merging this so the tests run. However, I have no idea about the modifications. I commented your fix out, so the tests will hopefully fail. |
|
@niccokunzmann the original issue is #187, there was a lot of discussion on this in #196 The main issue is that we currently parse invalid icalendar strings without any error message, i.e. with a wrong date type. |
Continuation of #196
See old PR for comments.