-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix encoding issues when using umlauts in from/to headers #405
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use plone.base.utils.safe_bytes
instead.
And the import at the top should be changed to plone.base.utils.safe_text
b2654ad
to
db6dbf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Requested changes have been made.
db6dbf0
to
c858d53
Compare
I rebased on master and force-pushed. |
Lots of test failures like this:
|
@MrTango I don't know why no tests show up here. But locally lots of tests fail like this:
I wonder if on Python 3 these headers need to be passed in as strings (text) anyway now... |
No description provided.