Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml stuff #496

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Yaml stuff #496

merged 4 commits into from
Dec 5, 2024

Conversation

einarmo
Copy link
Contributor

@einarmo einarmo commented Nov 25, 2024

No description provided.

This should be a lot cleaner and safer, witout any breaking changes.
@einarmo einarmo requested a review from a team as a code owner November 25, 2024 13:36
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 82.70440% with 55 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (f44a1f5) to head (637e326).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
Cognite.Config/YamlConfigBuilder.cs 81.01% 26 Missing and 4 partials ⚠️
Cognite.Config/Yaml/YamlEnumConverter.cs 55.55% 11 Missing and 1 partial ⚠️
Cognite.Config/Yaml/DefaultFilterTypeInspector.cs 90.16% 1 Missing and 5 partials ⚠️
Cognite.Config/Configuration.cs 78.57% 3 Missing ⚠️
Cognite.Config/Yaml/ListOrStringConverter.cs 93.54% 1 Missing and 1 partial ⚠️
Cognite.Config/Yaml/TemplatedValueDeserializer.cs 92.59% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   79.10%   78.93%   -0.17%     
==========================================
  Files         108      114       +6     
  Lines       10446    10566     +120     
  Branches     1596     1609      +13     
==========================================
+ Hits         8263     8340      +77     
- Misses       1547     1588      +41     
- Partials      636      638       +2     
Files with missing lines Coverage Δ
Cognite.Config/KeyVault.cs 76.00% <ø> (-5.04%) ⬇️
Cognite.Config/Yaml/ListOrStringConverter.cs 93.54% <93.54%> (ø)
Cognite.Config/Yaml/TemplatedValueDeserializer.cs 92.59% <92.59%> (ø)
Cognite.Config/Configuration.cs 87.87% <78.57%> (+6.03%) ⬆️
Cognite.Config/Yaml/DefaultFilterTypeInspector.cs 90.16% <90.16%> (ø)
Cognite.Config/Yaml/YamlEnumConverter.cs 55.55% <55.55%> (ø)
Cognite.Config/YamlConfigBuilder.cs 81.01% <81.01%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cognite-bulldozer cognite-bulldozer bot merged commit 21f08c8 into master Dec 5, 2024
4 checks passed
@cognite-bulldozer cognite-bulldozer bot deleted the yaml-stuff branch December 5, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants