Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some utils for stream records #493

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Some utils for stream records #493

merged 3 commits into from
Nov 19, 2024

Conversation

einarmo
Copy link
Contributor

@einarmo einarmo commented Nov 14, 2024

No description provided.

@einarmo einarmo requested a review from a team as a code owner November 14, 2024 11:17
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 14.75410% with 52 lines in your changes missing coverage. Please review.

Project coverage is 78.77%. Comparing base (f44a1f5) to head (309f5d3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Cognite.Extensions/StreamRecordExtensions.cs 10.52% 34 Missing ⚠️
ExtractorUtils/Cognite/CogniteDestination.cs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   79.10%   78.77%   -0.33%     
==========================================
  Files         108      109       +1     
  Lines       10446    10507      +61     
  Branches     1596     1600       +4     
==========================================
+ Hits         8263     8277      +14     
- Misses       1547     1595      +48     
+ Partials      636      635       -1     
Files with missing lines Coverage Δ
Cognite.Extensions/CdfMetrics.cs 100.00% <100.00%> (ø)
Cognite.Extensions/CogniteUtils.cs 81.49% <100.00%> (+0.04%) ⬆️
ExtractorUtils/Configuration/BaseConfig.cs 96.92% <100.00%> (+0.09%) ⬆️
ExtractorUtils/Cognite/CogniteDestination.cs 78.40% <0.00%> (-4.42%) ⬇️
Cognite.Extensions/StreamRecordExtensions.cs 10.52% <10.52%> (ø)

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einarmo einarmo merged commit de68c22 into master Nov 19, 2024
5 checks passed
@einarmo einarmo deleted the ila-utils branch November 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants