Duplicating sections #2008
Merged
Duplicating sections #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier than exposing icon font based icon to scrolled. REDMINE-20217
Create deep copy and deeply assign new perma ids. REDMINE-20217
Scrolled frontend code is active once section thumbnail has been rendered. Editor UI already implements a more decent focus style.
Re-index section positions. REDMINE-20217
Re-index positions. Render content elements in response to seed newly created section in client without separate request. REDMINE-20217
Use new controller end-points. Optimistically set positions. REDMINE-20217
Do not leave outline when inserting or duplicating sections. REDMINE-20217
REDMINE-20217
tf
force-pushed
the
duplicate-section
branch
from
55e50ec to
67e5ec6
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
entry_types/scrolled/spec/controllers/pageflow_scrolled/editor/sections_controller_spec.rb
Show resolved
Hide resolved
entry_types/scrolled/spec/controllers/pageflow_scrolled/editor/sections_controller_spec.rb
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-20217, REDMINE-18019
fixes #1951