Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video border size on About Us page #2375

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Fix video border size on About Us page #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
028972e
Fix video border size on About Us page
geetanjaligit Oct 24, 2024
5837170
Applied suggested changes based on PR feedback
geetanjaligit Oct 26, 2024
aa92d0f
Resolved merge conflict
geetanjaligit Oct 30, 2024
bcdfeee
Merge branch 'main' into anshu_fix/about-us-layout
geetanjaligit Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/User/pages/AboutUs/Aboutus.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,24 @@ const AboutUs = () => {
doorstep.
</p>
</div>

<div class="md:w-1/2 md:p-4 mt-10">
<div class="aspect-w-16 aspect-h-9 border-8 border-green-600 rounded-md ">
<iframe
className="md:w-[685px] md:h-[410px] w-[300px] h-[150px]"
// width="685"
// height="415"
src="https://www.youtube.com/embed/F9aJdlUGd08?autoplay=1&loop=1&playlist=F9aJdlUGd08&mute=1"
title="YouTube video player"
frameborder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share"
referrerpolicy="strict-origin-when-cross-origin"
allowfullscreen></iframe>
<div class="md:w-1/2 md:p-4 mt-10"> {/*Responsive width with padding for medium screens and up*/}
<div className="w-full max-w-2xl mx-auto border-8 border-green-600 rounded-md">{/*Centered container with responsive max width and border*/}
<div className="relative overflow-hidden" style={{ paddingTop: "56.25%" }}> {/* 16:9 Aspect Ratio for responsive video scaling */}
<iframe
className="absolute top-0 left-0 w-full h-full"
src="https://www.youtube.com/embed/F9aJdlUGd08?autoplay=1&loop=1&playlist=F9aJdlUGd08&mute=1"
title="YouTube video player"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
referrerpolicy="strict-origin-when-cross-origin"
allowFullScreen
loading="lazy" //Improves loading performance by deferring iframe load
aria-label="About VigyBag" //Accessibility improvement: describes video content
></iframe>
</div>
</div>
</div>
</div>
</div>
</div>

</section>
<div className="w-full h-2 opacity-10 bg-slate-900"></div>
<section className="py-3 md:py-20 md:h-[90vh]">
Expand Down
2 changes: 1 addition & 1 deletion tailwind.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default {
'pop': ['Poppins'],
'baloo': ["Baloo 2", 'sans-serif'],
'roboto': ['Roboto', 'sans-serif'],
}
},
},
},
plugins: [],
Expand Down