-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make responsive of About page and route name correction #2226
Conversation
@SadafKausar2025 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes involve standardizing route paths in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant Privacy
participant TermsAndConditions
participant ReturnAndCancellation
User->>App: Navigate to privacy-policy
App->>Privacy: Render Privacy Component
User->>App: Navigate to terms-and-condition
App->>TermsAndConditions: Render Terms and Conditions Component
User->>App: Navigate to return-and-cancellation
App->>ReturnAndCancellation: Render Return and Cancellation Component
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/App.jsx (5 hunks)
- src/User/pages/AboutUs/Aboutus.jsx (8 hunks)
Files skipped from review due to trivial changes (1)
- src/App.jsx
Additional comments not posted (8)
src/User/pages/AboutUs/Aboutus.jsx (8)
10-10
: Responsive Text Size Adjustment ApprovedThe use of Tailwind CSS utility classes (
md:text-5xl text-3xl
) for the "Our Mission" heading effectively adjusts the text size based on the screen width, aligning well with the PR's objective to enhance responsiveness.
14-15
: Responsive Padding and Width Settings ApprovedThe use of responsive settings (
md:w-1/2 md:p-14
) for the text block ensures that the layout remains visually appealing and functional across different screen sizes.
29-31
: Responsive Iframe Dimensions ApprovedThe use of responsive classes (
md:w-[685px] md:h-[410px] w-[300px] h-[150px]
) for the iframe dimensions instead of fixed width and height attributes significantly improves the adaptability of the video display across various screen sizes.
44-44
: Consistent Responsive Text Size for Headings ApprovedThe consistent use of responsive text sizes (
md:text-5xl text-3xl
) for the "Our Story" heading, similar to the "Our Mission" heading, ensures a uniform and accessible user experience across different devices.
62-62
: Responsive Text Size for Paragraphs ApprovedThe responsive text size settings (
md:text-xl text-lg
) for the paragraph in the "Our Story" section enhance readability across different devices, aligning with the PR's objectives to improve user experience.
77-83
: Responsive Design in 'Why Choose VigyBag?' Section ApprovedThe responsive text sizes and class settings in the "Why Choose VigyBag?" section, including various text elements and layout adjustments (
md:text-lg text-sm
,md:w-1/2 p-14
), maintain a cohesive and accessible design across different screen sizes.Also applies to: 96-105
134-134
: Responsive Image Settings in 'Our Values' Section ApprovedThe use of responsive aspect ratio classes (
md:aspect-w-16 md:aspect-h-9
) for images in the "Our Values" section ensures that they scale properly across different devices, enhancing the visual appeal and user experience.
129-129
: Responsive Text Size for Paragraphs in 'Our Values' Section ApprovedThe responsive text size settings for the paragraphs in the "Our Values" section ensure that the text is readable and accessible on various devices, aligning with the PR's objectives to improve user experience.
Also applies to: 134-134
Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨ |
Fixes Issue
Changes proposed
Screenshots
Note to reviewers
Summary by CodeRabbit
privacy
toprivacy-policy
).