-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump kube-openapi version #421
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Francesco Ilario <[email protected]>
Remove the no more needed fake GOPATH implementation Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the openapi tool 🙏
I've tested and it works fine for me.
My folder structure is pretty standard so let's wait for others to test it as well before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, worked well for me too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me
@@ -10,48 +10,48 @@ require ( | |||
k8s.io/apimachinery v0.25.0 | |||
k8s.io/code-generator v0.25.0 | |||
k8s.io/gengo v0.0.0-20211129171323-c02415ce4185 | |||
k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1 | |||
k8s.io/kube-openapi v0.0.0-20240430033511-f0e62f92d13f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a Thought , Do we need to discuss/resolve the update to kube-openapi version as i see PR https://github.com/codeready-toolchain/api/pull/409/files from @ranakan19 updating it to some different version , and here it updates to some latest version? wont that be conflicting or may be just duplication of work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! As kube-openapi is a controller-runtime indirect dependency, maybe it's worth to merge the other PR first and then just remove the FAKE GOPATH logic with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fbm3307! I was thinking the same, but I wonder why there are no errors with the kube-openapi version you are upgrading to (which is the latest version) with the older controller-runtime version. Looking into this further.
As for merging the PR - I cannot merge the other PR untill all the other PRs across all repos are ready - so it may take another sprint or two to get to that stage. Would it be okay to wait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i see, the version you are updating to is the latest one from controller-runtime, not from the version of the controller-runtime we are currently on or would like to update it. It also has a higher version golang version. Since there is no error in upgrading to the latest version, because it is an indirect dependency, you could update the kube-openapi to this version if you need it for something. If not, I'd rather keep them updated in sync with the rest of the dependencies.
The version of kube-openapi for controller-runtime v0.15 is https://github.com/kubernetes-sigs/controller-runtime/blob/release-0.15/go.mod#L71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should definitely keep them updated in sync. Unfortunately, we'll not being able to remove FAKE GOPATH implementation until -if I'm not mistaken- [email protected].
Quality Gate passedIssues Measures |
@filariow probably we should put the PR to draft and pick up later or close this ( as per the above discussion) |
Description
Update kube-openapi version and removes Fake GOPATH implementation
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (host-operator, member-operator)? noIn case of new CRD, did you the following? NA
In case other projects are changed, please provides PR links. NA