Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goos configuration in goreleaser to support only Linux #72

Closed
wants to merge 14 commits into from

Conversation

ryan-gang
Copy link
Collaborator

This pull request updates the goos configuration in goreleaser to support only Linux. Previously, it supported both Linux and Darwin. The goos configuration is now set to only Linux, which ensures that the build process is optimized for Linux environments.

@ryan-gang ryan-gang self-assigned this Dec 17, 2024
@ryan-gang
Copy link
Collaborator Author

ryan-gang commented Dec 17, 2024

Our original release setup fails due to CGO dependencies in vterm.
Ref: https://github.com/codecrafters-io/shell-tester/actions/runs/12368284615/job/34517981427
Cross compiling for multiple distributions on linux was proving impossible, so broke up the build process for linux & darwin to run on their corresponding os runners.
Updated releaser config and the CI action.

@ryan-gang ryan-gang requested a review from rohitpaulk December 17, 2024 09:13
builds:
- main: ./cmd/tester/main.go
binary: tester
env:
- CGO_ENABLED=0
- CGO_ENABLED=1
Copy link
Member

@rohitpaulk rohitpaulk Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-gang with CGO enabled I think we're going to run into errors running this on alpine. That's why we had CGO set to 0 previously. Can you confirm that this works fine on alpine?

@ryan-gang
Copy link
Collaborator Author

ryan-gang commented Dec 17, 2024

CGO_ENABLED=1 build fails to run on alpine.

@ryan-gang ryan-gang closed this Dec 17, 2024
@ryan-gang ryan-gang deleted the vterm-pkg branch December 17, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants