refactor: update how we clean our vt row before asserting on it #373
ryan-gangAnnotations
15 errors and 1 warning
|
test
Fixture file ./test_helpers/fixtures/missing_command/no_output does not exist. To create a new one, use CODECRAFTERS_RECORD_FIXTURES=true
|
|
test
stdout:
|
|
test
stdout:
|
|
test
test] Error 1
|
|
test
Process completed with exit code 2.
|
|
lint:
internal/assertions/assertion_error.go#L13
comment on exported method ErrorMessage should be of the form "ErrorMessage ..." (ST1020)
|
|
lint:
internal/async_reader/async_reader.go#L40
comment on exported method Read should be of the form "Read ..." (ST1020)
|
|
lint:
internal/screen_asserter/screen_asserter.go#L10
comment on exported type ScreenAsserter should be of the form "ScreenAsserter ..." (with optional leading article) (ST1021)
|
|
lint:
internal/shell_executable/shell_executable.go#L189
comment on exported method GetLogger should be of the form "GetLogger ..." (ST1020)
|
|
lint:
internal/shell_executable/virtual_terminal.go#L10
comment on exported type VirtualTerminal should be of the form "VirtualTerminal ..." (with optional leading article) (ST1021)
|
|
lint:
internal/shell_executable/virtual_terminal.go#L42
comment on exported method GetScreenState should be of the form "GetScreenState ..." (ST1020)
|
|
lint:
internal/test_cases/command_response_test_case.go#L13
comment on exported type CommandResponseTestCase should be of the form "CommandResponseTestCase ..." (with optional leading article) (ST1021)
|
|
lint:
internal/test_cases/composite_screen_state_test_case.go#L8
comment on exported type CompositeScreenStateTestCase should be of the form "CompositeScreenStateTestCase ..." (with optional leading article) (ST1021)
|
|
lint:
internal/utils/utils.go#L39
comment on exported function BuildCleanedRow should be of the form "BuildCleanedRow ..." (ST1020)
|
|
lint:
internal/utils/utils.go#L47
func allCellsAreTheSame is unused (U1000)
|
|
test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|