2876 no copilot for ba comment #953
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: services/repository.py
Did you find this useful? React with a 👍 or 👎 |
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 443 443
Lines 35750 35781 +31
=======================================
+ Hits 35034 35065 +31
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
services/repository.py
Outdated
| @@ -39,6 +44,7 @@ | |||
| def get_repo_provider_service( | |||
| repository: Repository, | |||
| installation_name_to_use: str = GITHUB_APP_INSTALLATION_DEFAULT_NAME, | |||
| additional_data: AdditionalData = {}, | |||
There was a problem hiding this comment.
Apparently this is not recommended.
See https://docs.astral.sh/ruff/rules/mutable-argument-default/
|
This PR includes changes to |
The copilot AI button appears in every PR comment but should not appear in the BA PR comment. This solution adds a way to specify the upload type and manipulate the data being sent in Shared.
Haven't added tests to confirm approach is good but will do once I get the green light.
This PR needs to be updated to the latest shared once that merges in. codecov/shared#452
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.