Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to expose JUnit artifacts #950

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

michelletran-codecov
Copy link
Contributor

@michelletran-codecov michelletran-codecov commented Dec 6, 2024

This will allow us to download the junit xml files that gets generated during CI run. Having the raw file will be useful for debugging test analytics stuff.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@michelletran-codecov michelletran-codecov force-pushed the expose_junit_artifact branch 3 times, most recently from d594629 to b625fc2 Compare December 6, 2024 15:55
@codecov-notifications
Copy link

codecov-notifications bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (bdc738f) to head (a684d98).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         443      443           
  Lines       35750    35750           
=======================================
  Hits        35034    35034           
  Misses        716      716           
Flag Coverage Δ
integration 42.15% <ø> (ø)
unit 90.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 6, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@michelletran-codecov michelletran-codecov requested a review from a team December 13, 2024 16:09
@michelletran-codecov michelletran-codecov marked this pull request as ready for review December 13, 2024 16:09
@michelletran-codecov michelletran-codecov added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 2470ecc Dec 13, 2024
27 checks passed
@michelletran-codecov michelletran-codecov deleted the expose_junit_artifact branch December 13, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants