Closes #3 group membership support w/LDAP #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
I've made an attempt at adding group support for this plugin using the java LDAP JNDI interface. One thought I'm having is potentially users would want this to be optional, let me know what you think.
I definitely would like to hear any feedback you have on this pull request. I was wondering if you had any suggestions around testing the LDAP connection portion of this, I know it works in my deployment elastic/shield enviroment with a Windows Active Directory setup, but I'm not sure how you would construct an integration test for this in Java or if there are any recommended approaches here.
Java is not my native programming language so to speak 😃 so any best practices I've missed or any suggestions on how things could be done better are welcome.
Let me know,
Erik