Refector Python bot to Java #3
Conversation
|
I should be available for most of the weekend if anyone needs me to host the bot or provide the API key as part of their code review. |
|
@colbygallup |
There was a problem hiding this comment.
Great work!
A chunk of questions I have are not explicitly related to this code so feel free to write off as out-of-scope.
As mentioned in one of the comments, I haven't tested (or really considered) much of the actual functionality; here I'm more focused on the code quality itself. Later this week, or at next week's meeting, we'll take a closer look at what we intend to have and make a full feature list on Notion just to make sure the bot's on the path we want!
I'll also check in the Directors meeting on Tuesday to see if there's any functionality they'd like to see here.
|
@peterkos Finished looking through your review. Fixed some, debated others, moved a few to separate issues. Let me know if these are all fine or if further changes are needed. |
|
@peterkos Added most of the other suggestions. Just a couple more things to check, then we can merge this. |
Closes #2. This is a full re-implementation of the Python bot. It is not an identical copy; most notably, it features server-unique topic names and uses "topic" instead of "class". I will copy the other GitHub issues over from the old repository after this PR is closed.