support ordering grid groups using comparer function #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstijak
reviewed
May 17, 2024
| @@ -73,6 +73,7 @@ interface GridGroupingConfig { | |||
| caption?: StringProp; | |||
| name?: StringProp; | |||
| text?: StringProp; | |||
| comparer?: (a: any, b: any) => number; | |||
There was a problem hiding this comment.
Typing for the comparer arguments could be improved. Instead of any we should introduce a type.
interface GroupingResult {
key: any,
aggregates: any,
name: string,
results: any[]
}and whatever else is inside that object.
There was a problem hiding this comment.
The results field could also be typed similar to this:
interface GridProps<T = unknown>There was a problem hiding this comment.
Sure, will make the change. It was a copy/paste from column comparer definition. 🙂
* use MappedGridRecord type in DataAdapter * add GroupingResult<T> type for grouping config comparer * make grid grouping types generic
* modify FetchRecordsResult types * make MappedGridRecord extend DataAdapterRecord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.