Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor-quick-suggestions option. #183

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Add editor-quick-suggestions option. #183

merged 7 commits into from
Apr 5, 2024

Conversation

egenn
Copy link
Contributor

@egenn egenn commented Apr 5, 2024

Allow setting Monaco editor quickSuggestions option using quarto editor-quick-suggestions option,
defaulting to true.
solves #182

@coatless
Copy link
Owner

coatless commented Apr 5, 2024

@egenn thanks for the PR! I've add some quick documentation for the option. If you're okay with it, then I'll go ahead and merge it in.

@egenn
Copy link
Contributor Author

egenn commented Apr 5, 2024

@egenn thanks for the PR! I've add some quick documentation for the option. If you're okay with it, then I'll go ahead and merge it in.

Very nice - the default value for editor-quick-suggestions in the documentation should be true.

@egenn
Copy link
Contributor Author

egenn commented Apr 5, 2024

Scratch that - saw you made it false by default, which is great.

@coatless
Copy link
Owner

coatless commented Apr 5, 2024

Scratch that - saw you made it false by default, which is great.

@egenn 😄

Right now, suggestions are kind of meh. I might change the default back to true when #146 is addressed as that should greatly help with autocomplete suggestions.

That said, you can change the default options by specifying in the document yaml:

webr: 
  cell-options:
    editor-quick-suggestions: true

@egenn
Copy link
Contributor Author

egenn commented Apr 5, 2024

Scratch that - saw you made it false by default, which is great.

@egenn 😄

Right now, suggestions are kind of meh. I might change the default back to true when #146 is addressed as that should greatly help with autocomplete suggestions.

That said, you can change the default options by specifying in the document yaml:

webr: 
  cell-options:
    editor-quick-suggestions: true

Exactly, eventually they will be more helpful.

@coatless
Copy link
Owner

coatless commented Apr 5, 2024

In we go!

Thanks again for the PR! 🎉

@coatless coatless merged commit 9093f08 into coatless:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants