포인트 기능 수정 #78
Merged
포인트 기능 수정 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
GIVEN53
reviewed
Nov 3, 2023
| * @since 1.3.0 | ||
| */ | ||
| @Query("SELECT count(h) FROM HealthMetric h WHERE h.healthMetricId.oauthId = ?1 AND h.groupCode = ?2 AND h.healthMetricId.createdAt = ?3") | ||
| int findByGroupCode(String oauthId, GroupCode groupCode, LocalDate createdAt); |
There was a problem hiding this comment.
P3) 메서드에 무엇을 조회하는지 명시되어있으면 좋겠어요 그리고 JavaDoc은 "건강지표 조회"인데 쿼리는 count()를 리턴하다보니 혼동이 생깁니다!
| * @since 1.3.0 | ||
| */ | ||
| public static EarnPoint findByGroupCode(GroupCode groupCode) { | ||
| switch (groupCode) { |
There was a problem hiding this comment.
P4) java 12 버전부터 switch 문에서 람다를 사용할 수 있게 되었어요 현재 17 버전을 사용하고 있는 만큼 람다로 가독성을 올려보는 건 어떨까 생각합니다!
| public void addHealthMetricPoint(String oauthId, LocalDate date, GroupCode groupCode) { | ||
| User user = userSearchService.findUserByOauthId(oauthId); | ||
| int healthMetric = healthMetricSearchService.findByGroupCode(oauthId, groupCode, date); | ||
| if (healthMetric == 1) { |
Analysis Details0 Issues
Coverage and Duplications
Project ID: co-niverse_dangjang-backend_AYj2jZJELehUZAlqDvRk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 📝
Details 🌼
Check List ☑️