Notification fluent bit 연결 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
13wjdgk
force-pushed
the
feat/makeNotification
branch
from
3bf0d97 to
5899140
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GIVEN53
reviewed
Oct 14, 2023
| * @author EVE | ||
| * @since 1.1.0 | ||
| */ | ||
| public record FcmMessage(String registrationTokens, String title, String body) { |
There was a problem hiding this comment.
P2) lambda function에서 데이터를 읽을 때
{
"registration_token" : "fcm 토큰",
"title" : "푸시 알림 제목",
"body" : "알림 내용"
}의 값을 기대해요
token 복수형 제거해주시고
Suggested change
| public record FcmMessage(String registrationTokens, String title, String body) { | |
| public record FcmMessage(@JsonProperty("registration_token")String registrationToken, String title, String body) { |
으로 수정이 필요할 것 같습니다
| @Slf4j | ||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class NotificationFluentbitService { |
There was a problem hiding this comment.
P3) FluentBit이 만약 다른 도구로 변경되면 클래스명, 메서드명 전부 수정해야 하는 상황이 생길 것 같아요
| @@ -10,5 +11,6 @@ | |||
| * @author EVE | |||
| * @since 1.1.0 | |||
| */ | |||
| public interface NotificationTypeRepository extends JpaRepository<NotificationType, Long> { | |||
| @Repository | |||
| public interface NotificationTypeRepository extends JpaRepository<NotificationType, String> { | |||
There was a problem hiding this comment.
P3) 1차 MVP 배포 후에 타입은 ENUM으로 관리하도록 수정하는건 어떨까 싶습니다
| @@ -10,6 +16,14 @@ | |||
| * @author EVE | |||
| * @since 1.1.0 | |||
| */ | |||
| @Repository | |||
| @@ -10,5 +11,6 @@ | |||
| * @author EVE | |||
| * @since 1.1.0 | |||
| */ | |||
| public interface NotificationTypeRepository extends JpaRepository<NotificationType, Long> { | |||
| @Repository | |||
| * @author EVE | ||
| * @since 1.0.0 | ||
| */ | ||
| public class InvalidNotificationTypeException extends BusinessException { |
There was a problem hiding this comment.
P3) notification 패키지 하위에 있는게 좋을 것 같아요
| -- ("운동 기록 !", "오늘 운동을 기록해보세요 ~ ", '2023-10-10', "기록", "11111111", false), | ||
| -- ("체중 기록!", "오늘 체중을 기록해보세요 ~ ", '2023-10-08', "기록", "22222222", true), | ||
| -- ("접속해주세요!", "오늘은 접속 안하셨네요 ~ 접속해서 포인트 받아가세요", '2023-10-09', "접속", "22222222", false), | ||
| -- ("운동 기록 !", "오늘 운동을 기록해보세요 ~ ", '2023-10-10', "기록", "11111111", false); |
There was a problem hiding this comment.
나중에 알림 더미테이터가 필요할때를 대비해서 남겨뒀어요 !
| * notificationType을 찾을 수 없을 때 발생 | ||
| * | ||
| * @author EVE | ||
| * @since 1.0.0 |
| @Test | ||
| void notificationType을_조회한다() { | ||
| //given | ||
| LocalDate date = LocalDate.now(); |
|
|
||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| @SpringBootTest | ||
| class NotificationSearchServiceTest { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: co-niverse_dangjang-backend_AYj2jZJELehUZAlqDvRk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 📝
작업 내용을 작성합니다.
Details 🌼
구현 방식, 공유 사항, 스크린샷 등 해당 PR에 대한 상세한 내용을 작성합니다.
Check List ☑️
[Optional] Etc
Reference 등 추가적인 내용이 있을 경우 작성합니다. 이외에는
Etc를 삭제합니다.