Change json scema lib #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 13, 2024 09:40
…onschema/v6 Signed-off-by: Yury Rudichev <[email protected]>
Signed-off-by: Yury Rudichev <[email protected]>
Signed-off-by: Yury Rudichev <[email protected]>
urfinjuezz
force-pushed
the
changeJsonScemaLib
branch
from
d190f20 to
4d05bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a library that supports all scheme parameters, including the more recent draft-2020-12 (https://github.com/santhosh-tekuri/jsonschema). This library is easily integrated into cnab-go, I have an almost ready-made solution. But there is a nuance, the library does not return an error if incorrect content Encoding is passed, this will change the behavior, and actually I created a pullRequest in which I changed the library and corrected the tests for new error texts. I deleted one test, this is due to the behavior that I described above