Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digital outputs and analog inputs, stability fixes to servos #3

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

benmalenfant
Copy link
Member

No description provided.

@benmalenfant benmalenfant requested a review from McCaroon May 24, 2023 04:46
@McCaroon
Copy link
Member

Changes Requested: Decrease frequency of ROS message for vbus1 and vbus2

After discussing with @GLDuval, we discovered that the ROS message frequency vbus1 and vbus2 is set too high at 60 Hz. Do you think you could adjust it to a lower value?

Aside from that, everything else in the code looks good to me.

@benmalenfant benmalenfant force-pushed the Dev branch 2 times, most recently from e13da7e to d805a69 Compare May 28, 2023 17:27
@benmalenfant
Copy link
Member Author

let's get this moving

Copy link
Member

@Leuchak Leuchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply remove comments from .vscode/extensions.json

.vscode/extensions.json Show resolved Hide resolved
@benmalenfant benmalenfant requested a review from Leuchak October 30, 2023 03:40
Leuchak
Leuchak previously approved these changes Oct 30, 2023
Copy link
Member

@Leuchak Leuchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test

Copy link

@patates-cipsi418 patates-cipsi418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git ignore can be updated to remove .vscode/* files

}

//----------------------------------------------------------------
if(1){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants