Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dom): invalid memcopy and trailing char bug in fuzzer #8

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Oct 18, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@liuq19 liuq19 marked this pull request as draft October 18, 2023 15:54
@PureWhiteWu PureWhiteWu linked an issue Oct 18, 2023 that may be closed by this pull request
cargo bench
cargo bench check
cargo fuzz check
cargo +nightly fuzz run fuzz_value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargo +nightly fuzz run fuzz_value
cargo +nightly fuzz run fuzz_value -- -max_total_time=5m

Otherwise the fuzzer will run indefinitely if no issues are found.

@Shnatsel
Copy link

CI fails because cargo-fuzz is not installed.

The fix is cargo install cargo-fuzz, but compiling it may take a while unless https://github.com/Swatinem/rust-cache or some other form of caching is used.

@liuq19 liuq19 changed the title fix: invalid memcopy bug in fuzzer fix: invalid memcopy and trailing char bug in fuzzer Oct 18, 2023
@liuq19 liuq19 changed the title fix: invalid memcopy and trailing char bug in fuzzer fix(dom): invalid memcopy and trailing char bug in fuzzer Oct 18, 2023
@liuq19 liuq19 marked this pull request as ready for review October 18, 2023 17:00
@liuq19
Copy link
Collaborator Author

liuq19 commented Oct 18, 2023

This fixed #7

@liuq19 liuq19 enabled auto-merge (rebase) October 18, 2023 17:27
@liuq19 liuq19 merged commit 4b5f2fa into main Oct 19, 2023
7 checks passed
@liuq19 liuq19 deleted the fix/fuzz branch October 19, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Heap buffer overflow found by fuzzer
3 participants