Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy fixes #6

Merged
merged 11 commits into from
Oct 18, 2023
Merged

Clippy fixes #6

merged 11 commits into from
Oct 18, 2023

Conversation

chris-ha458
Copy link
Contributor

I used clippy to activate some lints to apply some fixes.
Nothing major. Mostly stylistic and idiomatic fixes.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chris-ha458 @PureWhiteWu
parser.rs fixes
5e75c90
@chris-ha458 @PureWhiteWu
point.rs fixes
fd0fad4
@chris-ha458 @PureWhiteWu
tree.rs fixes
be4d62d 
change import into specific imports
@chris-ha458 @PureWhiteWu
num\mod.rs fix typo
23fef11
@chris-ha458 @PureWhiteWu
\num\mod.rs
86e1516 
fix if structure
@chris-ha458 @PureWhiteWu
string.rs
47bad4f 
- fix imports
- fix if structures
@chris-ha458 @PureWhiteWu
iterator.rs
656e25e 
- explicit matching
@chris-ha458 @PureWhiteWu
Update de.rs
f269368 
- fix imports
- change let-match pattern to let-else pattern
@chris-ha458 @PureWhiteWu
Update ser.rs
071c4aa 
- merge identical arms
@chris-ha458 @PureWhiteWu
Update node.rs
d1ba462 
- fix iterations
- fix struct definition
@chris-ha458 @PureWhiteWu
cargo fmt
a93b572
PureWhiteWu
PureWhiteWu approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@PureWhiteWu PureWhiteWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for your contribution!

@PureWhiteWu PureWhiteWu merged commit c838482 into cloudwego:main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-ha458 @CLAassistant @PureWhiteWu