fix: call conn.release method in ext.ReleaseBodystream #1252
+97
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duslia
force-pushed
the
fix/release_body_stream
branch
2 times, most recently
from
b3eba17 to
bbedaf7
Compare
YangruiEmma
reviewed
Dec 24, 2024
| @@ -1425,6 +1425,7 @@ func TestStreamNotEnoughData(t *testing.T) { | |||
| err = ext.ReleaseBodyStream(req.BodyStream()) | |||
| assert.Nil(t, err) | |||
| assert.DeepEqual(t, 0, len(conn.Data)) | |||
| assert.DeepEqual(t, true, conn.HasReleased) | |||
Duslia
force-pushed
the
fix/release_body_stream
branch
from
bbedaf7 to
b5534a4
Compare
jayantxie
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
在 ext.ReleaseBodystream 中调用 conn.Release() 方法
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: In a streaming scenario, if there is a large amount of remaining data on the connection, all of it will be read into memory when skipRest is performed, which may lead to an OOM error.
zh(optional): 在流式场景下，如果连接上剩余数据很多时，在 skipRest 时会全部读到内存中，可能导致 OOM。
(Optional) Which issue(s) this PR fixes:
(Optional) The PR that updates user documentation: