optimize: Fix error reporting during server shutdown process #1065 #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er shutdown Signed-off-by: YarBor <[email protected]>
|
|
FGYFFFF
changed the title
|
@welkeyever Hey, is there anything to improve on this PR? |
welkeyever
reviewed
May 28, 2024
pkg/network/standard/transport.go
Outdated
| "time" | ||
|
|
||
| "github.com/cloudwego/hertz/pkg/common/config" | ||
| "github.com/cloudwego/hertz/pkg/common/hlog" | ||
| "github.com/cloudwego/hertz/pkg/network" | ||
| ) | ||
|
|
||
| const ( | ||
| transportAlive int32 = 0 |
Sorry for the late, I'll take look |
welkeyever
reviewed
May 28, 2024
pkg/network/standard/transport.go
Outdated
| @@ -100,7 +110,12 @@ func (t *transport) Close() error { | |||
| return t.Shutdown(ctx) | |||
| } | |||
|
|
|||
| func (t *transport) IsCallShutdown() bool { | |||
There was a problem hiding this comment.
Only for internal use, maybe no need to public it?
Signed-off-by: YarBor <[email protected]>
|
@YarBor Plz rebase develop and fix the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
修复服务器shutdown过程中的报错问题
(Optional) Which issue(s) this PR fixes:
#1065
(Optional) The PR that updates user documentation: