feat: parent retriever/indexer #16
Open
+480
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 152 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 148 | 4 | 0 | 0 |
Click to see the invalid file list
- flow/indexer/parent/parent.go
- flow/indexer/parent/parent_test.go
- flow/retriever/parent/parent.go
- flow/retriever/parent/parent_test.go
meguminnnnnnnnn
force-pushed
the
feat/wdz/parent
branch
from
9395eef to
e6b0a9e
Compare
|
go-test-coverage report: |
|
|
meguminnnnnnnnn
force-pushed
the
main
branch
from
1eb08b1 to
cc39e05
Compare
meguminnnnnnnnn
force-pushed
the
feat/wdz/parent
branch
from
e6b0a9e to
7ad2207
Compare
|
|
||
| if subDoc.ID == currentID { | ||
| continue | ||
| } |
There was a problem hiding this comment.
i == 0 的时候，一定会 continue？
There was a problem hiding this comment.
对，等到id发生变化之后更新之前的docid
There was a problem hiding this comment.
这里是假定了同一个 parent doc 的 sub doc，ID 一定是相同的？
meguminnnnnnnnn
force-pushed
the
feat/wdz/parent
branch
3 times, most recently
from
471c382 to
8d65eb9
Compare
meguminnnnnnnnn
force-pushed
the
feat/wdz/parent
branch
from
8d65eb9 to
b39dd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add parent retriever/indexer