Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(platform): optimization of project structure #149

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

Skyenought
Copy link
Collaborator

@Skyenought Skyenought commented Jan 1, 2024

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en: optimization of project structure

  • 将 shared/config 中的子文件夹移除, 提到 config 目录
  • 将 cmd/internal/option 包改为 args package, 并放入 shared, 保证 cmd 目录的纯净
  • 修改 dockerfile
  • 移除 utils 中的 internal package
  • 并没有对业务逻辑进行修改

Which issue(s) this PR fixes:

@Skyenought Skyenought changed the title optimize(platform): optimization of project structure WIP:optimize(platform): optimization of project structure Jan 1, 2024
@Skyenought Skyenought marked this pull request as draft January 1, 2024 13:57
@Skyenought Skyenought changed the title WIP:optimize(platform): optimization of project structure optimize(platform): optimization of project structure Jan 1, 2024
@Skyenought Skyenought marked this pull request as ready for review January 1, 2024 14:25
@Skyenought Skyenought requested a review from li-jin-gou January 1, 2024 14:25
@StellarisW StellarisW changed the title optimize(platform): optimization of project structure refactor(platform): optimization of project structure Jan 1, 2024
@@ -6,7 +6,7 @@ function api_gen() {
cd cmd/api
for file in ${api_files[@]}; do
hz update \
--module github.com/cloudwego/cwgo/platform/server/cmd/api \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 server 的话如何区分前端和后端的项目,现在都混在一起了

@li-jin-gou li-jin-gou merged commit 203b523 into cloudwego:main Jan 3, 2024
6 checks passed
@Skyenought Skyenought deleted the config branch July 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants