feat(platform): api service change to stateless #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-jin-gou
reviewed
Dec 28, 2023
|
|
||
| type Registry struct { | ||
| agentCache *cache.Cache | ||
| rdb redis.UniversalClient |
li-jin-gou
reviewed
Dec 28, 2023
| continue | ||
| } | ||
| case *redis.Client: | ||
| err := r.scanServiceKeysAndUpdate(rdb) |
There was a problem hiding this comment.
扫全表 redis，一般 redis 的运维会禁用这个操作
There was a problem hiding this comment.
- 这里需要调整实现.
- 另外这里实现的注册和发现都是给 API 用的嘛.
There was a problem hiding this comment.
已更改redis的更新方式，
通过监控一个hash key和一个redis channel实现
li-jin-gou
reviewed
Dec 28, 2023
| @@ -47,6 +47,8 @@ type ConsistentHashDispatcher struct { | |||
| hasher *consistent.Consistent | |||
| Tasks map[string]*model.Task | |||
| ServiceWithTasks map[string]map[string]*model.Task | |||
|
|
|||
| IdlIdToTaskIdMap map[int64]string | |||
There was a problem hiding this comment.
目前想通过 idl id 删除 task，只有加这个map才能实现
li-jin-gou
reviewed
Dec 28, 2023
| "github.com/redis/go-redis/v9" | ||
| ) | ||
|
|
||
| func NewRedisRegistry(rdb redis.UniversalClient) *redisregistry.Registry { |
There was a problem hiding this comment.
builtin是只将 agent 服务信息存储在内存，redis是将 agent 服务信息保存在redis中
Skyenought
force-pushed
the
feat-platform-stateless
branch
3 times, most recently
from
ba490d2 to
3d106a2
Compare
Skyenought
force-pushed
the
feat-platform-stateless
branch
2 times, most recently
from
344611e to
3f54952
Compare
Skyenought
force-pushed
the
feat-platform-stateless
branch
from
3f54952 to
2f04e17
Compare
Skyenought
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it (en: English/zh: Chinese):
en: api service change to stateless
zh: 将 api 服务变成无状态的
进行的改动:
Which issue(s) this PR fixes:
#136