Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for default values in FindInMap #2159

Closed
wants to merge 2 commits into from
Closed

Adding support for default values in FindInMap #2159

wants to merge 2 commits into from

Conversation

the-jules
Copy link
Contributor

markpeek
markpeek reviewed Aug 10, 2023
View reviewed changes
troposphere/__init__.py Outdated
find_in_map_details = [self.getdata(mapname), toplevelkey, secondlevelkey]

if defaultvalue is not None:
find_in_map_details.append(defaultvalue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change. If I'm reading the documentation correctly, shouldn't this be:

    find_in_map_details.append({'DefaultValue': defaultvalue})

And corresponding changes in the tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original thought was that the fourth item is essentially a dict type which would mean inputting "{'DefaultValue': defaultvalue}" in the template itself, but I suppose this is cleaner, I updated the PR.

@markpeek
Copy link
Member

Thanks! Merged locally to fix formatting via 7533fba

@markpeek markpeek closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpeek markpeek markpeek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-jules @markpeek