-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pluginpresets): deletion protection for plugin preset #809
base: main
Are you sure you want to change the base?
feat(pluginpresets): deletion protection for plugin preset #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unrelated commits from the PR. There are missing requirements from #804 will they be provided on separate PRs?
3cbf942
to
40d15c1
Compare
Fixed |
40d15c1
to
44ea878
Compare
…n annotation is set (#804)
c7bb8e6
to
04de769
Compare
@IvoGoman |
Description
I implemented validation in the webhook to prevent the deletion of plugin presets when the greenhouse.sap/prevent-deletion annotation is present.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist