[opentelemetry] add templating for ceph and kvm #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
viennaa
reviewed
Jan 2, 2025
Comment on lines
+1
to
+3
| {{- define "kvm.labels" }} | ||
|
|
||
| {{- end }} |
There was a problem hiding this comment.
Suggested change
| {{- define "kvm.labels" }} | |
| {{- end }} |
Is this needed?
Comment on lines
+197
to
+198
| - set(attributes["network.protocol.name"], ConvertCase(attributes["network.protocol.name"], "lower")) where attributes["network.protocol.name"] != nil | ||
| - set(attributes["config.parsed"], "ingress-nginx") where attributes["client.address"] != nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
This PR adds a functionality to enable/disable common log configuration for logs for Ceph and KVM.
Both logtypes can be disabled/enabled in the PluginDefinition. In case of enabling, the logs-collector.yaml will be enriched by KVM/Ceph specific labels, parsing and defined pipelines.
The goal is to reduces the complexity of the logs-collector configuration and provide standard log configuration for common scenarios.
Corresponding Roadmap issue: #515