RFC-0030 - Add support to Diego for file based service bindings #942
Conversation
dimitardimitrov13
changed the title
.gitmodules
Outdated
| url = https://github.com/dimitardimitrov13/bbs | ||
| branch = CFAR-929_VCAP_SERVICES | ||
| [submodule "src/code.cloudfoundry.org/auctioneer"] |
There was a problem hiding this comment.
This looks to me like an unwanted change here
There was a problem hiding this comment.
Yes, you're right. I need to run the Diego Release test suite first. After it passes, the modules will be reverted.
| # Define the service binding root directory | ||
| volume_mounted_files="/var/vcap/data/rep/shared/garden/volume_mounted_files" | ||
|
|
||
| # Calculate the size for the tmpfs (1MB per container) |
There was a problem hiding this comment.
This is going to increase the size of the diego footprint on the cell, which will reduce space for the containers themselves.
❓ Is additional space taken into account when the rep reports the resources on the cell to the BBS? It should be taken into account when this property is set to "auto".
There was a problem hiding this comment.
Hello, that's new for me. Would you elaborate further on this? Thanks.
There was a problem hiding this comment.
From my understanding, this https://github.com/cloudfoundry/executor/blob/main/initializer/configuration/configuration.go#L115 should be extended to add number_of_containers * 1MB to account for the 'overhead' that 'volume_mounted_files' will bring. Am I correct?
There was a problem hiding this comment.
Yes! That looks correct to me.
Summary
This PR is continuation for the RFC-0030
Backward Compatibility
Breaking Change? No
This feature is the first PoC for RFC-0030.
Since the CAPI implementation for RFC-0030 is not done yet, the PR doesn't need to be applied immediately.