Unmarshal Route JSON instead of parsing as a string #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Seth Boyles <[email protected]> Co-authored-by: Merric de Launey <[email protected]> Co-authored-by: David Alvarado <[email protected]>
davewalter
approved these changes
Aug 30, 2022
sorry, wrong PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Seth Boyles [email protected]
Co-authored-by: Merric de Launey [email protected]
Co-authored-by: David Alvarado [email protected]
What is this change about?
Similar to #587, this test is failing on latest CAPI since it is parsing JSON responses as strings (considering whitespace, etc).
Please provide contextual information.
cloudfoundry/cloud_controller_ng#2930
cloudfoundry/capi-release#262
What version of cf-deployment have you run this cf-acceptance-test change against?
release-candidate
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
n/a
How many more (or fewer) seconds of runtime will this change introduce to CATs?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@xandroc
@MerricdeLauney
@dalvarado