Convert get_config_var return to string
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting issues installing `sasl==0.3.1`:
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/private/var/folders/81/kqvp0vjx63gfg5cbczsprwp00000gp/T/pip-install-4567bfnx/sasl_c72464a3686149948899242d98362bd1/setup.py", line 35, in <module>
python_target = LooseVersion(
File "/usr/local/Cellar/[email protected]/3.8.9/Frameworks/Python.framework/Versions/3.8/lib/python3.8/distutils/version.py", line 304, in __init__
self.parse(vstring)
File "/usr/local/Cellar/[email protected]/3.8.9/Frameworks/Python.framework/Versions/3.8/lib/python3.8/distutils/version.py", line 312, in parse
components = [x for x in self.component_re.split(vstring)
TypeError: expected string or bytes-like object
```
The specific source of the problem is that `get_config_var('MACOSX_DEPLOYMENT_TARGET')` was returning the integer `11`
This is a bug that was shipped in Python3.8 and Python3.9: https://bugs.python.org/issue42504
The comment above this section of code references a code pattern from Pandas. Pandas also experienced this bug
and fixed it here: pandas-dev/pandas#38766
This commit implements the same fix.
As a workaround while this is prepped for release, I was able to `export MACOSX_DEPLOYMENT_TARGET=11`
prior to running the install so that it skipped over the broken code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting issues installing
sasl==0.3.1:The specific source of the problem is that
get_config_var('MACOSX_DEPLOYMENT_TARGET')was returning the integer11This is a bug that was shipped in Python3.8 and Python3.9: https://bugs.python.org/issue42504
The comment above this section of code references a code pattern from Pandas. Pandas also experienced this bug
and fixed it here: pandas-dev/pandas#38766
This commit implements the same fix.
As a workaround while this is prepped for release, I was able to
export MACOSX_DEPLOYMENT_TARGET=11prior to running the install so that it skipped over the broken code.