Fix powershell errors and update C# #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lucas:
I'm just now working on the next release of cljr.
Your changes seem reasonable.
However, due to the policy established by the Clojure team, PRs are not
accepted on official Clojure projects, of which clr.core.cli.
The general mechanism is patches, so I could use the patches.
However, also due to policy, I cannot accept code from someone unless they
have signed a contributor agreement with Clojure.
Available here: Clojure - Contributor Agreement
<https://clojure.org/dev/contributor_agreement>
If you do that, I can pull in your patches and get them in the next release.
…-David
On Fri, Jun 14, 2024 at 7:53 PM Lucas Teles ***@***.***> wrote:
I got some errors because my home path contains spaces.
Also, got some warnings because the script could the powershell $PROFILE
I start this as a simple refactoring modernizing the C# code and I end up
fixing those issues too.
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- 9145322
<9145322>
reorganization and better windows xp
File Changes
(5 files <https://github.com/clojure/clr.core.cli/pull/1/files>)
- *M* src/dotnet/Cljr/Cljr.csproj
<https://github.com/clojure/clr.core.cli/pull/1/files#diff-34a081f94c8e376a230159309482952d00c3b6cd675db88a5005d937f2823b19>
(171)
- *M* src/dotnet/Cljr/CommandLineParser.cs
<https://github.com/clojure/clr.core.cli/pull/1/files#diff-9c7def1be19252e738e8cb24cf0f7be8fa299cea5a7d84a8a56da8c28acc0a68>
(10)
- *M* src/dotnet/Cljr/ParseItems.cs
<https://github.com/clojure/clr.core.cli/pull/1/files#diff-4a1453217bcb0a7f088a86e6c5c6f6f0b474a3d527dbb8791aaed63c3e571acf>
(28)
- *A* src/dotnet/Cljr/Platform.cs
<https://github.com/clojure/clr.core.cli/pull/1/files#diff-e64049b2308d765ad8138d41ddf381a74497426f5288eed0d072929616779898>
(11)
- *M* src/dotnet/Cljr/Program.cs
<https://github.com/clojure/clr.core.cli/pull/1/files#diff-d233b5fd4806d9b048421db9491ef3895d932c5de8f6e8b4239b44f161edf9a8>
(940)
Patch Links:
- https://github.com/clojure/clr.core.cli/pull/1.patch
- https://github.com/clojure/clr.core.cli/pull/1.diff
—
Reply to this email directly, view it on GitHub
<#1>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUVZPBFS2HSRIXS6YK4L3ZHN655AVCNFSM6AAAAABJLFCRQWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TIMRWG44DANA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
You mention two issues that were fixed by your patch. |
I just signed it.
Sure! 1
Validating the cpFile existence to better feedback: 2
This is for skipping the load of user profile and bypassing the execution policy when executing PowerShell |
|
Ah, I see.
The diff on Program.cs was so large it wasn't displaying and I just didn't
notice the "diff to big view" marker at the bottom of the page.
I'll review and get a new version out soon.
THanks for the work on this.
…On Wed, Dec 11, 2024 at 1:11 PM Lucas Teles ***@***.***> wrote:
@dmiller <https://github.com/dmiller>
However, also due to policy, I cannot accept code from someone unless they
have signed a contributor agreement with Clojure.
I just signed it.
Could you elaborate on how the patch actually fixed those issues?
Sure!
------------------------------
1
I got some errors because my home path contains spaces.
When adding to ArgumentList, check if it contains an space and quote it:
https://github.com/clojure/clr.core.cli/pull/1/files?short_path=34a081f#diff-d233b5fd4806d9b048421db9491ef3895d932c5de8f6e8b4239b44f161edf9a8R499-R506
Validating the cpFile existence to better feedback:
https://github.com/clojure/clr.core.cli/pull/1/files#diff-d233b5fd4806d9b048421db9491ef3895d932c5de8f6e8b4239b44f161edf9a8R223-R224
2
Also, got some warnings because the script could the powershell $PROFILE
This is for skipping the load of user profile and bypassing the execution
policy when executing PowerShell
https://github.com/clojure/clr.core.cli/pull/1/files?short_path=34a081f#diff-d233b5fd4806d9b048421db9491ef3895d932c5de8f6e8b4239b44f161edf9a8R499-R506
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUVZMOJC76RFHQVWY43I32FB53XAVCNFSM6AAAAABJLFCRQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWG4ZTSMBRHE>
.
You are receiving this because you were mentioned.Message ID: <clojure/clr
.***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some errors because my home path contains spaces.
Also, got some warnings because the script could the powershell
$PROFILEI start this as a simple refactoring modernizing the C# code and I end up fixing those issues too.