Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vue): Expose initialValues prop within <SignInButton /> and <SignUpButton /> #4801

Merged
merged 2 commits into from
Dec 18, 2024
Merged

chore(vue): Expose initialValues prop within <SignInButton /> and <SignUpButton /> #4801

merged 2 commits into from
Dec 18, 2024

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Dec 17, 2024 •
edited
Loading

Description

We are exposing the initialValues prop in the React SDK within unstyled components here. This PR ports that into the Vue SDK.

<template>
  <SignUpButton
    :initial-values="{ emailAddress: '[email protected]' }"
  />
</template>

No major version yet so just patching this one

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b828743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/vue Patch
@clerk/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 9:42pm

@wobsoriano wobsoriano marked this pull request as ready for review December 17, 2024 21:42
@wobsoriano wobsoriano changed the title chore(vue): Expose initialValues prop within < SignInButton /> and <SignUpButton /> chore(vue): Expose initialValues prop within <SignInButton /> and <SignUpButton /> Dec 17, 2024
@wobsoriano wobsoriano merged commit aeb5855 into main Dec 18, 2024
37 checks passed
@wobsoriano wobsoriano deleted the rob/add-initial-value-prop-to-unstyled-components branch December 18, 2024 14:46
@clerk-cookie clerk-cookie mentioned this pull request Dec 18, 2024
Merged
BRKalow pushed a commit that referenced this pull request Dec 20, 2024
@wobsoriano @BRKalow
chore(vue): Expose initialValues prop within <SignInButton /> and…
8c6fe3b 
… `<SignUpButton />` (#4801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anagstef anagstef anagstef approved these changes

@nikospapcom nikospapcom nikospapcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wobsoriano @nikospapcom @anagstef