Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TTFs to v1.002 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

davelab6
Copy link

  • I set nbspace to same width as space:
ER: InknutAntiqua-Black.ttf space 239 nbsp 279: Change nbspace to 239
ER: InknutAntiqua-Bold.ttf space 254 nbsp 279: Change nbspace to 254
ER: InknutAntiqua-ExtraBold.ttf space 247 nbsp 279: Change nbnpace to 247
ER: InknutAntiqua-Light.ttf space 284 nbsp 279: Change nbspace to 284
ER: InknutAntiqua-Medium.ttf space 274 nbsp 279: Change nbspace to 274
OK: InknutAntiqua-Regular.ttf space 279 nbsp 279
ER: InknutAntiqua-SemiBold.ttf space 269 nbsp 279: Change nbspace to 269
  • I set fstype to zero
ER: InknutAntiqua-Black.ttf 8: Change to 0
ER: InknutAntiqua-Bold.ttf 8: Change to 0
ER: InknutAntiqua-ExtraBold.ttf 8: Change to 0
ER: InknutAntiqua-Light.ttf 8: Change to 0
ER: InknutAntiqua-Medium.ttf 8: Change to 0
ER: InknutAntiqua-SemiBold.ttf 8: Change to 0
  • I changed the NAME Table naming scheme.

You have in the SemiBold:

    <namerecord nameID="1" platformID="3" platEncID="1" langID="0x409">
      Inknut Antiqua Light
    </namerecord>
    <namerecord nameID="2" platformID="3" platEncID="1" langID="0x409">
      Bold
    </namerecord>

This sort of thing is too clever :) It doesn't work everywhere and users get confused because they don't think that the SemiBold is hiding being the Bold weight of the Light family, they think its broken and not available. So I set all the style apart from Regular and Bold to use their own style name directly.

Also, the Medium was missing ID 16

All files had a typo in the descrption:

    <namerecord nameID="10" platformID="3" platEncID="1" langID="0x409">
      &#187;Inknut Antiqua&#171; is an Antiqua typeface for litterature and long-form text. It is designed to evoke Venetian incunabula and humanist manuscripts. It comes with a complement of typographical sorts and OpenType features for the purpose. The proportions of Inknut Antiqua make it well suited for low-resolution screens.
    </namerecord>

(litterature -> literature)

  • Only the Bold's macStyle should be non-zero, I set them that way
  • Vertical metrics were all over the place:
$ fontbakery-fix-vertical-metrics.py *tf
WARNING: Inconsistent OS/2.usWinAscent hhea.ascent OS/2.sTypoAscender

Parameter              InknutAntiqua-Black.ttf    InknutAntiqua-Bold.ttf    InknutAntiqua-ExtraBold.ttf    InknutAntiqua-Light.ttf    InknutAntiqua-Medium.ttf    InknutAntiqua-Regular.ttf    InknutAntiqua-SemiBold.ttf    
ymax                   1703                       1652                      1677                           1549                       1583                        1566                         1601                          
hhea.ascent            1500                       1688                      1594                           2063                       1938                        2000                         1875                          
OS/2.sTypoAscender     1500                       1688                      1594                           2063                       1938                        2000                         1875                          
OS/2.usWinAscent       1500                       1688                      1594                           2063                       1938                        2000                         1875                          
ymin                   -876                       -866                      -868                           -842                       -853                        -846                         -854                          
hhea.descent           -1000                      -1000                     -1000                          -1000                      -1000                       -1000                        -1000                         
OS/2.sTypoDescender    -1000                      -1000                     -1000                          -1000                      -1000                       -1000                        -1000                         
OS/2.usWinDescent      1000                       1000                      1000                           1000                       1000                        1000                         1000                          
hhea.lineGap           0                          0                         0                              0                          0                           0                            0                             
OS/2.sTypoLineGap      0                          0                         0                              0                          0                           0                            0                             
hhea total             2500                       2688                      2594                           3063                       2938                        3000                         2875                          
typo total             2500                       2688                      2594                           3063                       2938                        3000                         2875                          
win total              2500                       2688                      2594                           3063                       2938                        3000                         2875                          
UPM:Heights            1000:2579                  1000:2518                 1000:2545                      1000:2391                  1000:2436                   1000:2412                    1000:2455                     
UPM:Heights %          257 %                      251 %                     254 %                          239 %                      243 %                       241 %                        245 %                         

High Glyphs
InknutAntiqua-Black.ttf: uni0930094D0901 uni0930094D0945
InknutAntiqua-ExtraBold.ttf: uni0930094D0901

WARNING: Inconsistent hhea.ascent: InknutAntiqua-Bold.ttf, InknutAntiqua-ExtraBold.ttf, InknutAntiqua-Light.ttf, InknutAntiqua-Medium.ttf, InknutAntiqua-Regular.ttf, InknutAntiqua-SemiBold.ttf
WARNING: Inconsistent OS/2.sTypoAscender: InknutAntiqua-Bold.ttf, InknutAntiqua-ExtraBold.ttf, InknutAntiqua-Light.ttf, InknutAntiqua-Medium.ttf, InknutAntiqua-Regular.ttf, InknutAntiqua-SemiBold.ttf
WARNING: Inconsistent OS/2.usWinAscent: InknutAntiqua-Bold.ttf, InknutAntiqua-ExtraBold.ttf, InknutAntiqua-Light.ttf, InknutAntiqua-Medium.ttf, InknutAntiqua-Regular.ttf, InknutAntiqua-SemiBold.ttf

So I set them to 1703 / -876 / 0 :

$ fontbakery-fix-vertical-metrics.py *tf;
Parameter              InknutAntiqua-Black.ttf    InknutAntiqua-Bold.ttf    InknutAntiqua-ExtraBold.ttf    InknutAntiqua-Light.ttf    InknutAntiqua-Medium.ttf    InknutAntiqua-Regular.ttf    InknutAntiqua-SemiBold.ttf    
ymax                   1703                       1652                      1677                           1549                       1583                        1566                         1601                          
hhea.ascent            1703                       1703                      1703                           1703                       1703                        1703                         1703                          
OS/2.sTypoAscender     1703                       1703                      1703                           1703                       1703                        1703                         1703                          
OS/2.usWinAscent       1703                       1703                      1703                           1703                       1703                        1703                         1703                          
ymin                   -876                       -866                      -868                           -842                       -853                        -846                         -854                          
hhea.descent           -876                       -876                      -876                           -876                       -876                        -876                         -876                          
OS/2.sTypoDescender    -876                       -876                      -876                           -876                       -876                        -876                         -876                          
OS/2.usWinDescent      876                        876                       876                            876                        876                         876                          876                           
hhea.lineGap           0                          0                         0                              0                          0                           0                            0                             
OS/2.sTypoLineGap      0                          0                         0                              0                          0                           0                            0                             
hhea total             2579                       2579                      2579                           2579                       2579                        2579                         2579                          
typo total             2579                       2579                      2579                           2579                       2579                        2579                         2579                          
win total              2579                       2579                      2579                           2579                       2579                        2579                         2579                          
UPM:Heights            1000:2579                  1000:2518                 1000:2545                      1000:2391                  1000:2436                   1000:2412                    1000:2455                     
UPM:Heights %          257 %                      251 %                     254 %                          239 %                      243 %                       241 %                        245 %                         

@davelab6
Copy link
Author

Ping @clauseggers

@clauseggers
Copy link
Owner

Hey Dave. I’ve just had time to have a look at this, but I run into issues with the updated feature code that the new version(s) of Glyphs generate, so I’ll wait until I hear back from Georg.

@clauseggers
Copy link
Owner

Please checkout the branch backport and review the changes. I’ve changed the stuff you have listed, but fstype is not changed in Glyphs, so whether it is changed in the TTFs you will have to check with bakery. If they are not changed I will file an issue with Georg.

@davelab6
Copy link
Author

davelab6 commented Jul 6, 2015

@weiweihuanghuang
Copy link

screen shot 2015-07-06 at 6 44 27 pm
You just create a custom parameter fsType, and set it as 'not set', which displays as 'Installable' at the bottom.

@clauseggers
Copy link
Owner

Dave I know how to set the fsType in Glyphs. In Inknut fsType has been set since forever. Read what I'm writing: #5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants