HttpServer: Support for Unix Sockets #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use NetCoreServer to create an app for ctrlX OS. ctrlX OS secures access to app UI with a reverse proxy, but to prevent that local processes can hijack sensitive data, the app should listen on a unix socket instead of a local tcp port.
Currently, Kestrel is the only dotnet webserver able to listen on a unix socket, but NetCoreServer has a smaller footprint, can be published trimmed and even AOTed.
By adding one c'tor for HttpServer and TcpServer and a one-liner in TcpServer.CreateSocket, this capability can be added to NetCoreServer.
I was able to test the functionality successfully on Linux with the HttpServerUnixSocket sample, nginx and a browser. On Windows, I did just a simple curl test (and was surprised that Windows is able to create something like a unix socket :-)), which worked, too.