-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antmicro/yosys-systemverilog#1743: Compensate for chipsalliance/Surelog#3670 #522
base: main
Are you sure you want to change the base?
Conversation
I did run the PR + chipsalliance/Surelog#3670 in yosys-systemverilog CI, many tests fail: https://github.com/antmicro/yosys-systemverilog/actions/runs/5121636527 |
I ran the CI pipeline in Surelog repository and the build passed. chipsalliance/Surelog#3681 The UHDM/Surelog change should have minimal impact outside the core implementation itself. |
@mglb Any update on this PR? Anything I can do to bump up the priority on this? |
@hs-apotell |
Appreciate the update. Let me know when you are ready to try out this change again and I can rebase the Surelog PR. |
@hs-apotell FYI: you can fork yosys-systemverilog, change submodule revisions/remotes to point to your changes, commit+push, and create a Draft PR. The CI will test it using code from revisions/forks configured on your branch. Instructions how to change submodule can be found in the readme: https://github.com/antmicro/yosys-systemverilog#using-dedicated-branch |
Are the issues reported against Surelog master resolved? |
UHDM model hierarchy changed to enforce vpiParent as weak reference.
Every related issue reported against Surelog/UHDM has been fixed AFAIK. |
@mglb I forked the yosys-systemverilog repository and attempted a build it never gets executed. I have 3 builds waiting in the queue for over 10 hours. Am I missing some required permissions for the self-hosted runners? |
Custom runners are "private" to an org. In principle the only way for them to run for external users is to open a PR to that org (so in this case to https://github.com/antmicro/yosys-systemverilog). You cannot use them "privately" (unless you set up exactly the same "private" infrastructure) |
chipsalliance/synlig#1743: Compensate for chipsalliance/Surelog#3670
UHDM model hierarchy changed to enforce vpiParent as weak reference.