Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parmys (Partial Mapper for Yosys) plugin #421

Open
wants to merge 83 commits into
base: main
Choose a base branch
from

Conversation

poname
Copy link

@poname poname commented Dec 15, 2022

This PR provides Parmys (Partial Mapper for Yosys) plugin which performs intelligent partial mapping (inference, binding, and hard/soft logic trade-offs) from Odin-II.

@poname
Copy link
Author

poname commented Dec 15, 2022

@kgugala once the tests are passed, this PR is ready to be reviewed/merged.

@poname poname changed the title Parmys plugin Parmys (Partial Mapper for Yosys) plugin Dec 15, 2022
Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few initial comments. This PR is pretty big and I think the biggest issue is that it seems to copy code from other projects instead of adding them as a third_party dependency.

This will need to be solved before we can land this PR

parmys-plugin/include/BlockMemories.hpp Outdated Show resolved Hide resolved
parmys-plugin/parmys.cc Outdated Show resolved Hide resolved
parmys-plugin/parmys.cc Show resolved Hide resolved
parmys-plugin/include/odin_types.h Outdated Show resolved Hide resolved
* for loop syntax improved

* namespace refined

* just parmys ci for now

* reformatted

* all ci
@poname poname requested a review from kgugala January 6, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants