This repository has been archived by the owner on Mar 6, 2018. It is now read-only.
CHEF-5225: Clean up shmall and shmmax handling #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btm
changed the title
|
Looks alright in client code review. Ping @mmzyk |
|
Thanks @VictorLowther. As I stated on another PR of yours, we're in bug fix mode for the upcoming 11.1 release, so this won't make it, but we'll look to incorporate this into the release after that. |
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
|
Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of overspecializing how we set postgres-related sysctl values, just set shmall and shmmax directly only if we need to, and record the settings we used in /etc/sysctl.d/ for posterity.
This will work on all distros from approx. RHEL 6.x on. If we want RHEL 5.x support as well, that can be added fairly trivially.