Feature/partial readmes #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhan-okbay-cko
requested review from
deepesh-vasthimal-cko,
patrick-hoban-cko,
ehab-al-cko and
jheng-hao-lin-cko
okhan-okbay-cko
force-pushed
the
feature/partial-readmes
branch
3 times, most recently
from
4fffd36 to
af1020c
Compare
okhan-okbay-cko
commented
Sep 20, 2023
okhan-okbay-cko
commented
Sep 20, 2023
okhan-okbay-cko
force-pushed
the
feature/partial-readmes
branch
from
af1020c to
1e35bf7
Compare
okhan-okbay-cko
commented
Sep 20, 2023
patrick-hoban-cko
previously approved these changes
Sep 21, 2023
okhan-okbay-cko
requested review from
jheng-hao-lin-cko and
patrick-hoban-cko
okhan-okbay-cko
force-pushed
the
feature/partial-readmes
branch
from
504efef to
6876eaa
Compare
jheng-hao-lin-cko
approved these changes
Sep 21, 2023
ehab-al-cko
approved these changes
Sep 21, 2023
okhan-okbay-cko
added a commit
that referenced
this pull request
Oct 26, 2023
* Bump version to 4.2.0 * Update sample CocoaPods projects * Move Checkout.podspec * Remove Carthage references from README * Update pods on CI * Fix the recommended usage in README * Rename PaymentViewController * Fix a failing test * Add CodeQL GitHub Actions workflow * Fix Checkout tests * Bump version to 4.2.1 * Update sample project versions to exact versions * Add workflow * Remove PR checks from Bitrise in favour of GitHub Actions * Add regression tests workflow * Update snapshots * PIMOB-XXXX: Using recommended resource_bundles in podspec to fix static linking (#452) Co-authored-by: Ehab Alsharkawy <[email protected]> * Add checkout logo (#462) * Remove regression tests from bitrise.yml (#463) * Add codeowners file (#464) * PIMOB-2041 Add app store validation (#465) This allows us to see if we cause any disruptions by our SDK that will prevent our merchants' builds to be uploaded to App Store successfully * Remove bitrise.yml since we now use GitHub Actions (#466) * Update README.md (#460) * Update README (#467) * Add workflows to publish Checkout and Frames pods (#468) * Add SwiftLint as a blocker pre-check for all the other checks (#469) SwiftLint comes pre-installed on runner images of GitHub. SwiftLint will run before all the other checks. If SwiftLint fails, then all the other checks don't run. SwiftLint only runs for the new files to avoid a big PR. It also parses errors and warnings for the new files and shows them on GitHub UI. * Fix the fixable SwiftLint issues (#471) * Fix the fixable SwiftLint issues * Remove --strict flag from SwiftLint step under check-pr workflow * Produce a line length linter error after 210 characters * Move some folders around and update README (#473) Move some folders around and update README * Add lint edited files script (#475) * Create deploy-github-pages.yml (#476) * Create deploy-github-pages.yml * Rename the workflow * Add generate-jazzy-docs.yml (#474) * Add only docs diff (#478) * Update jazzy docs (#477) * Remove docs from root folder (#479) * Update SnapshotTesting framework version (#480) We needed to define an exact version since they stopped supporting iOS 12 in a minor version release. This broke our CI/CD pipeline. * Trigger regression and validation workflows via labels (#481) * Update the PR template (#483) * Feature/partial readmes (#482) * Create sub README files * Set README refs to main branch * Update jazzy docs (#484) Co-authored-by: runner <[email protected]> * Update README (#488) --------- Co-authored-by: cko-developer-portal[bot] <89167155+cko-developer-portal[bot]@users.noreply.github.com> Co-authored-by: bartlomiejswierad-vodeno <[email protected]> Co-authored-by: Ehab Alsharkawy <[email protected]> Co-authored-by: runner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our README was colossal. So, this created partial/sub READMEs
Preview available here: https://github.com/checkout/frames-ios/blob/1e35bf770c058c36c03f09e18451df051209db4a/README.md